search

brooklyn-data / dbt_artifacts

A dbt package for modelling dbt metadata. https://brooklyn-data.github.io/dbt_artifacts
Apache License 2.0
330 stars 125 forks source link

fct_dbt__critical_path is not showing the slowest path #52

Closed john-jerome closed 2 years ago

john-jerome commented 3 years ago

Hey there! We've been collecting dbt artifacts for a while now and already back when we started I noticed that the fct_dbt__critical_path table looked very suspicious (i.e. too good to be true) in our case, and it still does: Screenshot 2021-10-13 at 10 14 37

I tried to investigate this issue by looking at the structure of the fct_dbt__critical_path model and it seems that everything until search_path (node_ids, total_time) produces the expected results (in particular, in our case). I was just confused by the fact that total_time column seems to be a string instead of float. However, starting with the next CTE called longest_path_node_ids we are getting the wrong node sequence. There must be something that this case when does that I don't understand.

Any help would be appreciated!

NiallRees commented 2 years ago

Hey John - I think this should have been fixed by https://github.com/tailsdotcom/dbt_artifacts/pull/51. It hasn't been released yet, but could you try installing the latest commit to see if that fixes things?

packages.yml

  - git: "https://github.com/tailsdotcom/dbt_artifacts.git"
GenDemo commented 2 years ago

I am also still having this problem, and I installed last week.

NiallRees commented 2 years ago

I am also still having this problem, and I installed last week.

Please could you provide a screenshot of the model and share which version of dbt_artifacts you have installed?

GenDemo commented 2 years ago

Hi @NiallRees

Thnx for getting back to me. Sure, please see below:

image

image image

NiallRees commented 2 years ago

@GenDemo The latest version of the package is 0.6.0, could you give that a try?

GenDemo commented 2 years ago

Definitely - Today is my last day for the Christmas break, so it will be a while before I reply.

GenDemo commented 2 years ago

Cool, that seems to have worked! thnx :)