search

brooklynDev / airborne

RSpec driven API testing framework
MIT License
1.13k stars 122 forks source link

Fix ruby 2.4 Fixnum deprecation warnings #127

Closed iyedb closed 7 years ago

iyedb commented 7 years ago

Fixes #125

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.971% when pulling 1ca13aa16feda939d39722fa76015525680e3405 on iyedb:master into 2e7d93a0712c7937809ed272074dcfb3c6a1d9c7 on brooklynDev:master.

iyedb commented 7 years ago

Should be fixed by #127 pending merge.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.971% when pulling 3c6a92b5de54a36eb38692aafc2c3a049eecafa8 on iyedb:master into 2e7d93a0712c7937809ed272074dcfb3c6a1d9c7 on brooklynDev:master.

iyedb commented 7 years ago

Made the change you suggested. Thanks.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.971% when pulling 5848384c8edcd280d70c7081019d3c204580aa14 on iyedb:master into 2e7d93a0712c7937809ed272074dcfb3c6a1d9c7 on brooklynDev:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.971% when pulling 5848384c8edcd280d70c7081019d3c204580aa14 on iyedb:master into 2e7d93a0712c7937809ed272074dcfb3c6a1d9c7 on brooklynDev:master.

casiodk commented 7 years ago

@sethpollack Is it possible to merge this?

sethpollack commented 7 years ago

Done. Thanks!

sletix commented 7 years ago

I'm not sure, but I have same warnings after this merge:

/Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:239: warning: constant ::Fixnum is deprecated
/Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:239: warning: constant ::Bignum is deprecated
/Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:240: warning: constant ::Fixnum is deprecated
/Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:240: warning: constant ::Bignum is deprecated
/Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:241: warning: constant ::Fixnum is deprecated
/Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:241: warning: constant ::Bignum is deprecated
/Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:242: warning: constant ::Fixnum is deprecated
/Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:242: warning: constant ::Bignum is deprecated
/Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:243: warning: constant ::Fixnum is deprecated
/Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:243: warning: constant ::Bignum is deprecated
/Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:244: warning: constant ::Fixnum is deprecated
/Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:244: warning: constant ::Bignum is deprecated
iyedb commented 7 years ago

What is the version of your gem ?

On Apr 4, 2017 15:03, "Oleg Artamonov" notifications@github.com wrote:

I'm not sure, but I have same warnings after this merge:

/Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:239: warning: constant ::Fixnum is deprecated /Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:239: warning: constant ::Bignum is deprecated /Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:240: warning: constant ::Fixnum is deprecated /Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:240: warning: constant ::Bignum is deprecated /Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:241: warning: constant ::Fixnum is deprecated /Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:241: warning: constant ::Bignum is deprecated /Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:242: warning: constant ::Fixnum is deprecated /Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:242: warning: constant ::Bignum is deprecated /Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:243: warning: constant ::Fixnum is deprecated /Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:243: warning: constant ::Bignum is deprecated /Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:244: warning: constant ::Fixnum is deprecated /Users/sletix/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/airborne-a55e8e27ea74/lib/airborne/request_expectations.rb:244: warning: constant ::Bignum is deprecated

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/brooklynDev/airborne/pull/127#issuecomment-291492635, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnP1o49LXXWi0wHODJK5hQDW3kyoMzPks5rsj-GgaJpZM4MieRg .

sletix commented 7 years ago

I try master HEAD (a55e8e27) and v0.2.9

jondkinney commented 7 years ago

I'm seeing those deprecation warnings bundled to master as well. It looks like either of these PRs would fix things up...not sure why they were both closed without merging though...

https://github.com/brooklynDev/airborne/pull/128 https://github.com/brooklynDev/airborne/pull/131

[Update] actually, this PR looks to be the best: https://github.com/brooklynDev/airborne/pull/132

Hopefully we can get that merged in soon? I'll bundle to that fork for now...