search

brooklyncentral / brooklyn

This project has moved and is now part of the ASF
https://github.com/apache/incubator-brooklyn
72 stars 27 forks source link

Fix use of service command with iptables and deprecate old methods #1412

Closed grkvlt closed 10 years ago

grkvlt commented 10 years ago

This now uses two ways of running service depending on whether it is on the user's $PATH and an alternative command to save the rules if it is available. Also added more @Deprecated annotations where the obsolete Protocol enum was used.

% sudo service iptables save
% sudo /sbin/service iptables save
% sudo iptables-save
buildhive commented 10 years ago

Brooklyn Central » brooklyn #2319 FAILURE Looks like there's a problem with this pull request (what's this?)

Caused by: java.lang.NoClassDefFoundError: org/apache/maven/cli/MavenLoggerManager at org.jvnet.hudson.maven3.launcher.Maven3Launcher.main(Maven3Launcher.java:73)

grkvlt commented 10 years ago

This has been tested on both Ubuntu and CentOS machines, to verify that both ways of saving rules work properly.

aledsage commented 10 years ago

Looks good; merging.