search

brooklyncentral / brooklyn

This project has moved and is now part of the ASF
https://github.com/apache/incubator-brooklyn
72 stars 27 forks source link

Feature: policy persistence #1427

Closed aledsage closed 10 years ago

aledsage commented 10 years ago

@grkvlt - as discussed, can you begin reviewing this. I'm continuing to work on:

  1. feature-enablement for persisting policies + enrichers
  2. fix ControlledDynamicWebAppCluster's setting of members on rebind
  3. nginx losing its members for some reason
  4. check that enrichers + policies are cleaned up from persisted state when entity is unmanaged
grkvlt commented 10 years ago

@aledsage Reviewing

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2368 SUCCESS This pull request looks good (what's this?)

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2369 SUCCESS This pull request looks good (what's this?)

aledsage commented 10 years ago

@grkvlt I think this should be good for review (and merging once whatever comments you have are addressed). Note that policy persistence is disabled by default - see BrooklynFeatureEnablement.

grkvlt commented 10 years ago

@aledsage some minor points, none related to logic or structure, which looks sound

aledsage commented 10 years ago

@grkvlt I've incorporated your comments, except:

I also let another commit sneak in: adding PortAttributeSensorAndConfigKeyTest, which has a disabled failing test. I plan to open an issue very soon about this.

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2384 SUCCESS This pull request looks good (what's this?)

aledsage commented 10 years ago

Merging now; let me know if you have any further comments @grkvlt