search

brooklyncentral / brooklyn

This project has moved and is now part of the ASF
https://github.com/apache/incubator-brooklyn
72 stars 27 forks source link

entity initializers to define SSH sensors and effectors from yaml #1446

Closed ahgittin closed 10 years ago

ahgittin commented 10 years ago

start by looking at the documentation and the example therein, then look at the commits individually to see how it is built up

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2412 FAILURE Looks like there's a problem with this pull request (what's this?)

aledsage commented 10 years ago

closing+reopening to kick off build hive again.

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2434 FAILURE Looks like there's a problem with this pull request (what's this?)

ahgittin commented 10 years ago

huh - error seems legit:

[ERROR] Caused by: java.lang.NullPointerException: Cannot create effector sayHiNetcat with no impl (did you forget impl? or did you mean to buildAbstract?)
[ERROR] at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:236)
[ERROR] at brooklyn.entity.effector.Effectors$EffectorBuilder.build(Effectors.java:82)
[ERROR] at io.brooklyn.camp.brooklyn.VanillaBashNetcatYamlTest.<clinit>(VanillaBashNetcatYamlTest.java:33)

some last minute test-tidying that broke it. latest commit should fix it.

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2435 FAILURE Looks like there's a problem with this pull request (what's this?)

ahgittin commented 10 years ago

@buildhive you are having problems again

ERROR: Failed to parse POMs
hudson.remoting.ChannelClosedException: channel is already closed
at hudson.remoting.Channel.send(Channel.java:524)
at hudson.remoting.Request.call(Request.java:129)
at hudson.remoting.Channel.call(Channel.java:722)
at hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:167)
at $Proxy58.isAlive(Unknown Source)
at hudson.Launcher$RemoteLauncher$ProcImpl.isAlive(Launcher.java:930)
at hudson.maven.ProcessCache$MavenProcess.call(ProcessCache.java:165)

closing+reopening

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2437 SUCCESS This pull request looks good (what's this?)

nakomis commented 10 years ago

Reviewed, looks good to go :-)

aledsage commented 10 years ago

Lots of great stuff here. My biggest comment is that I need to think more about what the yaml would ideally look like when someone is adding sensors (e.g. for the JMX attributes to be polled).

aledsage commented 10 years ago

Please re-submit in https://github.com/apache/incubator-brooklyn/pulls, with a reference to this PR, and close this one. We can merge it from there.

richardcloudsoft commented 10 years ago

Hello, and thank you for your contribution to Brooklyn. We've moved house, so unfortunately we can't accept your pull request on this repository. You can read our new How to contribute guide, and read How to migrate your brooklyncentral fork to Apache. Our Community is available to help you if you have any trouble with the migration - or simply post a comment here and I will respond.

Thank you again for your contribution and we hope that you will submit your contribution again at our new home!