Closed nakomis closed 10 years ago
Brooklyn Central » brooklyn #2418 SUCCESS This pull request looks good (what's this?)
Brooklyn Central » brooklyn #2477 FAILURE Looks like there's a problem with this pull request (what's this?)
code looks good, some minor comments. have not tried running it though -- can you tell which clouds you've tested it in, and/or add a yaml recipe to try it out?
Mostly done - will wait for #1474 to be merged so I can use your Functionals and getRawRawType
Brooklyn Central » brooklyn #2516 SUCCESS This pull request looks good (what's this?)
Brooklyn Central » brooklyn #2521 SUCCESS This pull request looks good (what's this?)
Should now be good to go
Looks good - can we get an integration test? Then it's good to merge.
PR comments addressed
Brooklyn Central » brooklyn #2539 SUCCESS This pull request looks good (what's this?)
Closing this PR and re-opening in 'Brand new world'
NOTE: Clustering is done automatically by elasticsearch (using zen discovery) as it is not possible to reconfigure zen discovery at runtime. As a future improvement, cross-cloud support could be added using tribes