[WIP] Fixes for "deploy from Windows"

[neykov]

The changes necessary to get brooklyn-sample running on Windows. Must be started with "-Djava.io.tmpdir=C:/temp"

[buildhive]

Brooklyn Central » brooklyn #2425 FAILURE Looks like there's a problem with this pull request (what's this?)

[aledsage]

Failing test looks unrelated. We should ignore here, but fix in a separate pull request:

java.lang.UnsupportedOperationException: Catalogs cannot be added until the base catalog is loaded
at brooklyn.catalog.internal.BasicBrooklynCatalog.loadManualAdditionsCatalog(BasicBrooklynCatalog.java:153)
at brooklyn.catalog.internal.BasicBrooklynCatalog.addItem(BasicBrooklynCatalog.java:124)
at brooklyn.entity.rebind.RebindCatalogEntityTest.rebind(RebindCatalogEntityTest.java:98)
at brooklyn.entity.rebind.RebindCatalogEntityTest.testRestoresAppFromCatalogClassloader(RebindCatalogEntityTest.java:78)

Closing and re-opening PR, to kick off buildhive again.

[aledsage]

Thanks @neykov - changes all look good and sensible. Will wait for buildhive to run again, then happy for this to be merged.

[buildhive]

Brooklyn Central » brooklyn #2433 SUCCESS This pull request looks good (what's this?)

[buildhive]

Brooklyn Central » brooklyn #2440 SUCCESS This pull request looks good (what's this?)

[neykov]

One change that I haven't committed and keep local is the memory allocated for tools and apps. I am using the 32 bit VM which allows around 750mb heap (including permgen) so the existing values of 1g don't even allow the VM to start. I can easily switch VMs, but is 1g really needed? It will leave users wondering why they can't build and use the project.

The error while running the tests with default values is:

Error: Could not create the Java Virtual Machine.
Error occurred during initialization of VM
Could not reserve enough space for object heap
Error: A fatal exception has occurred. Program will exit.

[buildhive]

Brooklyn Central » brooklyn #2442 FAILURE Looks like there's a problem with this pull request (what's this?)

[ahgittin]

someone pls review #1458 soon as it's causing more and more unrelated build failures!

closing and reopening this one

[buildhive]

Brooklyn Central » brooklyn #2451 SUCCESS This pull request looks good (what's this?)

[buildhive]

Brooklyn Central » brooklyn #2460 SUCCESS This pull request looks good (what's this?)

[buildhive]

Brooklyn Central » brooklyn #2461 SUCCESS This pull request looks good (what's this?)

[buildhive]

Brooklyn Central » brooklyn #2462 SUCCESS This pull request looks good (what's this?)

[neykov]

Fixed the tabs in the same commits, apparently not a great idea since it hides the existing comments.

[neykov]

@ahgittin I will add comments explaining the jar change, the main reason is that it already works for all platforms. The change is in response to broken tests (ResourceUtilsTest.{testClassLoaderDirFromJar, testClassLoaderDirFromJarWithSlash}) which are testing this specific method. This is the reason why I haven't added additional tests.

[ahgittin]

minor comments. look good once addressed, and merge conflicts are fixed.

[buildhive]

Brooklyn Central » brooklyn #2540 SUCCESS This pull request looks good (what's this?)

[richardcloudsoft]

Hello, and thank you for your contribution to Brooklyn. We've moved house, so unfortunately we can't accept your pull request on this repository. You can read our new How to contribute guide, and read How to migrate your brooklyncentral fork to Apache. Our Community is available to help you if you have any trouble with the migration - or simply post a comment here and I will respond.

Thank you again for your contribution and we hope that you will submit your contribution again at our new home!