brooklyncentral / brooklyn

This project has moved and is now part of the ASF
https://github.com/apache/incubator-brooklyn
72 stars 27 forks source link

HA: detect when a node fails without warning #1456

Closed richardcloudsoft closed 10 years ago

richardcloudsoft commented 10 years ago

When a node goes AWOL - absent without leave, i.e. it has gone away unexpectedly without notifying anyone - this change will detect if the heartbeat period has expired and implicitly set the node state to FAILED.

aledsage commented 10 years ago

Nice; a few comments needing addressed before we can merge.

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2432 SUCCESS This pull request looks good (what's this?)

aledsage commented 10 years ago

Also some tests would be good.

aledsage commented 10 years ago

@richardcloudsoft is going to include https://github.com/aledsage/brooklyn/commit/68282fe74d90973d328339c703923ea461a7fa6c from the branch https://github.com/aledsage/brooklyn/tree/fix-subnet-tier-persistence

richardcloudsoft commented 10 years ago

Cherry-picked @aledsage's additions to this change, which addresses all comments above. Merging.