search

brooklyncentral / brooklyn

This project has moved and is now part of the ASF
https://github.com/apache/incubator-brooklyn
72 stars 27 forks source link

Fix attr when ready rebind 1422 #1457

Closed ahgittin closed 10 years ago

ahgittin commented 10 years ago

fix for #1422 - @aledsage @sjcorbett does this make sense?

it is just the last commit https://github.com/ahgittin/brooklyn/commit/ccfdfa430f2a69367c06f52b6e2768f49969bfd6 being submitted here, but it has some merge conflicts if we unpick #1452 so i've built on that.

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2436 FAILURE Looks like there's a problem with this pull request (what's this?)

aledsage commented 10 years ago

Looks good. A few minor comments.

Note I commented directly on commit https://github.com/ahgittin/brooklyn/commit/a6e8f464c27416ff0b42b08bbfbe2ec1ce78d44b, so probably best not to rebase that if you can get away with it. If you do, the comments will no longer show up in the pull request.

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2454 FAILURE Looks like there's a problem with this pull request (what's this?)

ahgittin commented 10 years ago

rebased, resolving conflicts in LookupContext (where signature of methods changed in HEAD not to take type, changed here to supply a ManagementContext)

ahgittin commented 10 years ago

merging as @aledsage 's comments have been addressed

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2469 SUCCESS This pull request looks good (what's this?)