block in catalog if someone tries to add something early

brooklyncentral / brooklyn

This project has moved and is now part of the ASF

https://github.com/apache/incubator-brooklyn

72 stars 27 forks source link

block in catalog if someone tries to add something early #1458

Closed ahgittin closed 10 years ago

ahgittin commented 10 years ago

fixes the intermittent error we've been getting, such as:

https://buildhive.cloudbees.com/job/brooklyncentral/job/brooklyn/2413/io.brooklyn$brooklyn-core/testReport/brooklyn.entity.rebind/RebindCatalogEntityTest/testRestoresAppFromCatalogClassloader/

does so by blocking if the catalog is not yet fully loaded when someone tries to add something manually to it. there are better fixes as noted in the code (manual additions could be done in bg) but this is a quicker pragmatic workaround.

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2438 SUCCESS This pull request looks good (what's this?)

grkvlt commented 10 years ago

As you say, this seems like the pragmatic solution @ahgittin There are some small stylistic changes I'd suggest before merging?

grkvlt commented 10 years ago

In the spirit of pragmatism, Im happy to merge since this fixes the @buildhive problems we're having just now, and address the stylistic concerns in a future PR?

aledsage commented 10 years ago

Agreed; merging now to fix buildhive errors.

p.s. @grkvlt don't use @buildhive unless you want the folk behind buildhive to pay attention. Or do you think they always ignore it when you say @buildhive?