search

brooklyncentral / brooklyn

This project has moved and is now part of the ASF
https://github.com/apache/incubator-brooklyn
72 stars 27 forks source link

add backoff support to the `Repeater`, and leverage it in Entities. has ... #1463

Closed ahgittin closed 10 years ago

ahgittin commented 10 years ago

...nice side effect of speeding up many of the tests which rely on this repeater, including SoftwareProcessSubclassTest which goes from 10s total to 1s total.

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2471 SUCCESS This pull request looks good (what's this?)

grkvlt commented 10 years ago

Great. Change the comment text and merge :frog:

aledsage commented 10 years ago

+1; I'm mostly ok with this code being commented out because the comment clearly says why. However, I would format it differently to put the // indented - i.e. so the code is part of the comment, rather than it looking like some arbitrarily commented out code.

Without the comment (of which the code is a concise way of saying it), we risk someone refactoring it to "simplify" the code at some point.

grkvlt commented 10 years ago

@ahgittin @aledsage Can just merge this as soon as you're happy with the comment issue