search

brooklyncentral / brooklyn

This project has moved and is now part of the ASF
https://github.com/apache/incubator-brooklyn
72 stars 27 forks source link

Keystore can be specified from brooklyn.properties, and tidies to use of temp dir and tidies in tests #1466

Closed ahgittin closed 10 years ago

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2476 SUCCESS This pull request looks good (what's this?)

grkvlt commented 10 years ago

Keystore code looks good. :frog: Otherwise, adding static method in EntityTestUtils and making a new TempFileInputStream class are the important comments. Not as bothered about returning Maybe although I think it'd be useful.

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2478 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2479 FAILURE Looks like there's a problem with this pull request (what's this?)

brooklyn.rest.resources.ApplicationResourceTest.testDeleteApplication

Error Message

apps=[BasicApplicationImpl{id=L9VE2goN}, RestMockApp{id=n758wuwE}, BasicApplicationImpl{id=jxQBsm7J}, BasicApplicationImpl{id=O66n0I6p}] expected [3] but found [4]

Stacktrace

java.lang.AssertionError: apps=[BasicApplicationImpl{id=L9VE2goN}, RestMockApp{id=n758wuwE}, BasicApplicationImpl{id=jxQBsm7J}, BasicApplicationImpl{id=O66n0I6p}] expected [3] but found [4]
    at org.testng.Assert.fail(Assert.java:94)
    at org.testng.Assert.failNotEquals(Assert.java:494)
    at org.testng.Assert.assertEquals(Assert.java:123)
    at org.testng.Assert.assertEquals(Assert.java:370)
    at brooklyn.rest.resources.ApplicationResourceTest.testDeleteApplication(ApplicationResourceTest.java:493)
grkvlt commented 10 years ago

@ahgittin Not sure about that test failure... But I think I've seen it before, so probably not related to this. You happy to merge, if the tests pass locally?

ahgittin commented 10 years ago

@grkvlt yeah tests pass for me. weird test error, i've added a bit more logging in case the failure happens again, but let's merge