search

brooklyncentral / brooklyn

This project has moved and is now part of the ASF
https://github.com/apache/incubator-brooklyn
72 stars 27 forks source link

Couchbase auto rebalance #1483

Closed nakomis closed 10 years ago

nakomis commented 10 years ago

Dependent upon #1481

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2525 SUCCESS This pull request looks good (what's this?)

ahgittin commented 10 years ago

nice and simple

might be cleaner to have an class-based effector (cf #1446 which still needs review BTW) as that allows optional parameters, e.g. add_server(boolean rebalance default true). but not needed at this point i don't think.

does anything untoward happen if we have several simultaneous add_server_and_rebalance calls? as in, if a rebalance is in progress does it stop you from doing another one? maybe worth asking and guarding against that corner case. but again not needed right now.

merging