search

brooklyncentral / brooklyn

This project has moved and is now part of the ASF
https://github.com/apache/incubator-brooklyn
72 stars 27 forks source link

bump maven-war-plugin version #1485

Closed ahgittin closed 10 years ago

ahgittin commented 10 years ago

(old version was fine here but new version needed in downstream projects),

along with the parameter which fixes the second copy overwriting the files changed by the replacer plugin (for war plugin v 2.1+)

confirmed the resulting WAR is identical apart from the pom changes

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2532 FAILURE Looks like there's a problem with this pull request (what's this?)

aledsage commented 10 years ago

buildhive failure looks unrelated (brooklyn.policy.loadbalancing.ItemsInContainersGroupTest.testItemUnmanagedIsRemoved). I'll take a look at that next. In mean time, closing and re-opening PR to kick off buildhive. What was the alternative magic incantation to do that?!

aledsage commented 10 years ago

Do we need to search all downstream projects for <maven-war-plugin.version>, and update them to 2.4 if they are on an older version? Or will they keep working?

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2533 SUCCESS This pull request looks good (what's this?)

aledsage commented 10 years ago

Non-deterministic test fixed in https://github.com/brooklyncentral/brooklyn/pull/1486

buildhive passed this time, so merging.