Remove uses of legacy code (OldJmxSensorAdapter and brooklyn.entity.basic.legacy.JavaApp)

brooklyncentral / brooklyn

This project has moved and is now part of the ASF

https://github.com/apache/incubator-brooklyn

72 stars 27 forks source link

Remove uses of legacy code (OldJmxSensorAdapter and brooklyn.entity.basic.legacy.JavaApp) #43

Open cosmin-dumitrache opened 12 years ago

cosmin-dumitrache commented 12 years ago

It looks like the Tomcat Server and JBoss AS6 Are still using OldJmxSensorAdapter and brooklyn.entity.basic.legacy.JavaApp.

They should use the newer classes as is done in JBoss7Server.

Things to do:

refactor those entities to use the newer code (and thus take advantage of jmx reconnect etc).
deprecate the old classes.
ensure any useful tests/code is scavenged from there.

ahgittin commented 12 years ago

definitely a good thing to do!

pveentjer commented 12 years ago

Is this task currently being picked up?

ahgittin commented 12 years ago

i think cosmin has wip on this -- see his partial pull req

pveentjer commented 12 years ago

Ok, great. Then I'll leave this task alone.

aledsage commented 12 years ago

Refactoring of JBoss6Server and TomcatServer has been done, and is in master.

Nginx is underway, and will be in pull request shortly hopefully.

The JBoss6Sever integration tests need a bit more love - Peter and Aled have looked at that some.

And TomcatServerTest is currently disabled due to annoying differences in behaviour for JMX MBean wildcards in a "normal" embedded MBeanServer and for the MBeanServer in Tomcat. This may be related to the JBoss6Server failure as well, where ObjectName wildcards are causing problems.