Closed aledsage closed 8 years ago
Test failure looks unrelated, and down to the travis infrastructure rather than our code? Everything passed, until the clocker-dist which failed with "Unable to calculate a request signature: Empty key".
Will force a rebuild anyway.
[INFO] Clocker Project (Parent) ........................... SUCCESS [ 9.929 s]
[INFO] Clocker Patches .................................... SUCCESS [ 32.943 s]
[INFO] Clocker Docker Integration ......................... SUCCESS [ 50.377 s]
[INFO] Brooklyn Clocker REST JavaScript Web GUI .......... SUCCESS [ 17.740 s]
[INFO] Clocker Mesos Integration .......................... SUCCESS [ 18.225 s]
[INFO] Clocker Web UI ..................................... SUCCESS [ 0.689 s]
[INFO] Clocker Distribution ............................... FAILURE [ 19.180 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:34 min
[INFO] Finished at: 2016-03-25T14:23:57+00:00
[INFO] Final Memory: 65M/481M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.bazaarvoice.maven.plugins:s3-upload-maven-plugin:1.2:s3-upload (default) on project brooklyn-clocker-dist: Execution default of goal com.bazaarvoice.maven.plugins:s3-upload-maven-plugin:1.2:s3-upload failed: Unable to calculate a request signature: Unable to calculate a request signature: Empty key -> [Help 1]
@aledsage regarding the unmanaged tasks, they appear as green now but if you try to invoke an effector on them they fail (due to the API call not correctly building the path its id is of the form basic-0.mysubdir
and its trying to hit that rather than mysubdir/basic-0
- unmanaged tasks without subdirs are fine tho)
2016-03-25 17:00:32,279 INFO REST invocation of MarathonTaskImpl{id=LqmrH3HE}.stop[] {}
2016-03-25 17:00:32,292 INFO Stopping MarathonTaskImpl{id=LqmrH3HE} when its state is running
2016-03-25 17:00:32,363 WARN Invalid response code 404: Not Found
Not a blocker imho, handling of unmanaged tasks in subdirs needs a bit of love.
Thanks @johnmccabe - merging now.
@grkvlt would appreciate you looking at this as well when you get a chance, even after it's been merged.
@aledsage Looked fine to me
@aledsage I'll test rebind shortly (as part of https://github.com/apache/brooklyn-server/pull/82) but the rest of the fixes LGTM, tested the unmanaged tasks handling using this gist (https://gist.github.com/johnmccabe/641fb30ed9450ca74e53 - handling tasks in dirs may need looked at)