search

brooklyncentral / clocker

Apache Brooklyn cloud native infrastructure blueprints
Apache License 2.0
428 stars 66 forks source link

Show unrelated marathon tasks #270

Open grkvlt opened 8 years ago

grkvlt commented 8 years ago

In the previous marathon/mesos integration, it created an entity to represent every Marathon task - including those that were not created by Clocker. This is clearly not good from a scalability point of view. For example, if we bind to an existing shared Mesos environment, it could have a huge number of unrelated marathon tasks.

This has been removed: we no longer create entities to create unrelated marathon tasks.

However, it is nice for demo purposes to show the other marathon tasks. We could add it back in as a config option (defaulting to false). If it is re-added, we need to be careful in its use and it will open up other problems we saw where unrelated tasks were marked as being "on-fire" in some situations (it is unclear what exactly those were).

aledsage commented 8 years ago

I'm unconvinced we want to add support for this - it's extra code that was previously buggy (showing those tasks as on-fire sometimes, and trying to poll the tasks at the wrong URL causing unnecessary work).

Though these things could be fixed, it is not a good thing to enable during production. Having it only for debug/demos seems like unnecessary effort and complexity.

grkvlt commented 8 years ago

@aledsage OK, and I'm also leaning towards removing some of the similar reporting for Docker too