search

brooklyncentral / clocker

Apache Brooklyn cloud native infrastructure blueprints
Apache License 2.0
428 stars 66 forks source link

Remove external resources #395

Closed grkvlt closed 7 years ago

grkvlt commented 7 years ago

Important This is required to let the Kubernetes catalog entries load when there is no external (public Internet) connectivity available to AMP.

Updates iconUrl to point at local files with classpath:// URIs and adds the icons as resources. Copies the brooklyn-dns BOM file to the target Jar so that it can be imported from a classpath:// URI also.

andreaturli commented 7 years ago

Why from http to classpath? Performance?

andreaturli commented 7 years ago

Ah no maybe it's for weird networks where those resources may be nor reachable

grkvlt commented 7 years ago

So that the BOM file can be loaded onto a Brooklyn server running somewhere that does not have Internet access, such as many large enterprises.

drigodwin commented 7 years ago

@grkvlt, have you checked if we have the rights to incorporate all these images in clocker? Do they meet whatever terms of use they have?

grkvlt commented 7 years ago

@drigodwin good point, will review the terms of use and update if required

grkvlt commented 7 years ago

See guidelines for Kubernetes, also others. Will document these links on the Wiki here.

grkvlt commented 7 years ago

@drigodwin have added license details for icons