broology / poker-moons

Free online poker with friends without the hassle.
4 stars 3 forks source link

feat: Ui Shared Buttons #148

Closed kevinfeddema closed 2 years ago

kevinfeddema commented 2 years ago

Proposed Changes

Builds all shared ui button components.

Linked Issue

closes #110 closes #111 closes #145

Types of changes

Merge Checklist

Deployment Notes

jordems commented 2 years ago

Yeah you'll need to name it something else. Can't be on****. Or events that already exist. So clicked or something like that would probably work

On Sun., Jun. 5, 2022, 5:06 p.m. Kevin Feddema, @.***> wrote:

@.**** commented on this pull request.

In libs/frontend/shared/ui/src/lib/buttons/primary-button/primary-button.component.ts https://github.com/broology/poker-moons/pull/148#discussion_r889754842:

+import { Component, Input, OnInit } from @./core'; +import { IconProp } from @./fontawesome-svg-core'; +import { faCoffee } from @./free-solid-svg-icons'; +import { ButtonColors } from './primary-button.type'; + @.({

  • selector: 'poker-moons-primary-button',
  • templateUrl: './primary-button.component.html',
  • styleUrls: ['./primary-button.component.scss'], +}) +export class PrimaryButtonComponent implements OnInit {
  • @Input() label?: string;
  • @Input() color?: ButtonColors;
  • @Input() startIcon?: IconProp;
  • @Input() endIcon?: IconProp;

Yeah so this is something I attempted back in the day. I tried it again and I got a compiler error Output bindings, including aliases, should not be named as standard DOM events. This also upsets the @angular-eslint/no-output-native lint rule. I'm assuming from this that onClicks are standard outputs handled by angular?

— Reply to this email directly, view it on GitHub https://github.com/broology/poker-moons/pull/148#discussion_r889754842, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFL5ZT3LEXKHRJ5GAVSBMFLVNU6IXANCNFSM5RF7AGXQ . You are receiving this because your review was requested.Message ID: @.***>