fix(backend): resolve turn timer circular dep issue - Githubissues

broology / poker-moons

Free online poker with friends without the hassle.

4 stars 3 forks source link

fix(backend): resolve turn timer circular dep issue #232

Closed jordems closed 2 years ago

jordems commented 2 years ago

Proposed Changes

Resolves the Turn Timer backend dependancy issue, so now the turn timer will actually work as intended.
- If a user runs out of round time and their time bank, then it will auto perform an action for them.
- User having 30 seconds per turn and a timebank of 5 minutes
Also realized the nomenclature for the JobSchedulerService wasn't accurate so updated this.

Linked Issue

resolves #187

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Merge Checklist

[x] My code follows the code style of this project.
[x] All new and existing tests passed.
[ ] Any dependent changes have been merged in downstream modules.
[x] I have provided inline technical documentation (tsdocs) where necessary.
[ ] My change requires a change to the root documentation.
[x] I have updated the documentation accordingly.

Deployment Notes