search

brospars / simple-calendar

Simple calendar jquery plugin
https://brospars.github.io/simple-calendar
MIT License
49 stars 38 forks source link

Avoid Bootstrap collisions [breaking change], prevent page scroll up, add onEventCreate and onDayCreate #19

Closed valerio-bozzolan closed 4 years ago

valerio-bozzolan commented 4 years ago

My dear,

I have some commits for you:

1 eaa681a85596a2fc8bcfb4f774f43b5a09285687 – BREAKING CHANGE: fix collision with every Bootstrap theme avoiding the .btn selector and adopt .calendar-btn

  1. 56cf6e0080d2f959219fc4b7efbcaf416c67da2c – prevent page scroll up when clicking on next/previous buttons
  2. 47c59da46dec248f365e767c0370b0f7224137b0 – add two more callbacks to simplify customization: onEventCreate and onDayCreate
  3. c0bfadae6cf0fb6fcca3cf37595095bd56d17ce3 – I see a lot of repositories with a README.md instead of readme.md so this is just a cosmetic rename.

The first change is very important to allow integration between this plugin and every Bootstrap-based theme in the world. Anyway it's not really a breaking change: if some people has customized your stylesheet can just update their selectors to restore their changes. People without customization will not notice any change. I've done this change because I would simplify integration and adoption of this beautiful plugin.

The second change is very important for single-page applications relying to hashtag changes in the URL, or very long pages when you should not scroll to the top of the page. Clicking on the next/previous buttons was causing the hashchange event, because you was visiting #.

The third change is crucial to allow some nice customization. For example, colorize some specific days or some specific events if they have some kind of data.

Apologies if I fucked up this GitHub page. I was forgotting something useful from my branch. Anyway the git history is clean.

Have fun! <3

brospars commented 4 years ago

Thank you for your great work.