brotkrueml / schema

TYPO3 extension providing an API and view helpers for schema.org markup
https://extensions.typo3.org/extension/schema
GNU General Public License v2.0
32 stars 9 forks source link

FAQ Pagetype is generated in automatic Breadcrumb #121

Closed dgorges closed 3 months ago

dgorges commented 3 months ago

There has been a ticket that if a FAQPage is selected, the FAQPage is created in the breadcrumb. https://github.com/brotkrueml/schema/issues/101. This has been solved. Thank you for that. But in the automatic breadcrumb of the eventlistener there is still the pagetype selected and causes Google to mark this as an error.

Therefore, the file: schema/Classes/EventListener/AddBreadcrumbList.php has to be updated also.

$givenItemType = ($page['tx_schema_webpagetype'] ?? '') ?: 'WebPage'; -> $givenItemType = 'WebPage';

After that, the behavior is streamlined with the breadcrumb viewhelper.