Open hi563145 opened 1 year ago
The documentation string likely needs to be improved. Does the documentation for the run
commands on the README.md help in clarifying things: https://github.com/brotzeit/rustic#run ?
Not really as the reason why I am confused is because I wanted to run in comint mode with specific command line argument (I have multiple binary crates). This lead me to look into the source code and notice the behavior is kinda inconsistent. I am curious about what you think about my proposal as I am looking into learning some elisp and might be able to contribute.
Confusion
rustic-cargo-run and rustic-cargo-comint-run
The documentation string says that when
arg
is nil, the value ofarg
would be used and stored inrustic-run-arguments
. However, the actual behavior is getting the value from mini buffer and storing it torustic-run-arguments
(rustic-run-comint-arguments
for rustic-cargo-comint-run).rustic-cargo-plain-run
The function does what the documentation says. However, if the
arg
isnil
it still reads the arguments from the mini buffer.Proposal
All rustic-cargo-run, rustic-cargo-plain-run and rustic-comint-run:
rustic-run-arguments
and use the value ifarg
is non-nil.rustic-cargo-use-last-stored-arguments
, when set tonil
will get and store the arguments to the common variable from mini buffer. When set to non-nil would use the common variable as arguments.cargo run
.Additional Features