search

brousalis / peteshow

a customizable javascript framework for filling out forms with fake data
MIT License
36 stars 13 forks source link

Expose Faker again #8

Open esambo opened 9 years ago

esambo commented 9 years ago

Faker used to be globally exposed which allowed the consuming Rails app to do things like: Faker.Address.streetAddress() But the introduction of gulp in #2 stopped doing this which now causes the error: Uncaught ReferenceError: Faker is not defined and stops Peteshow from loading.

I wouldn't mind if Faker would be scoped within Peteshow, but such a breaking change should probably be mentioned in a Changelog.md file

Affected apps based on a GitHub search are:

esambo commented 9 years ago

But why can't we make Faker globally accessible? It's a public library and not an implementation detail. It is a dependency. It is not modified by Faker and therefore probably should NOT live within the Peteshow namespace!

brousalis commented 9 years ago

It wasn't on purpose. When Kevin did the gulp changeover, he broke that on accident.

I'll fix it shortly.

esambo commented 9 years ago

There seem to be some other errors too when trying to fill out a form with Peteshow

brousalis commented 9 years ago

I think its pretty safe to say Kevin's gulp implementation is broken and master is dirty. I'll revert everything.

However I never released his changes to the gem itself, so the gem is still stable.

esambo commented 9 years ago

Yes, 0.8.6 (referencing ref 1d93e3f) works, and rebasing #2 onto that last commit before gulp works fine

itsthatguy commented 9 years ago

Hey!

itsthatguy commented 9 years ago

Digging into all of this now