search

brown-ccv / OmniReferenceClient

Reference client for the OMNI system
0 stars 0 forks source link

feat: lead integrity test button #107

Closed broarr closed 3 years ago

broarr commented 3 years ago

As discussed with Dave this morning, we want a button for lead integrity tests instead of it happening automatically on record

broarr commented 3 years ago

Good catch!

On Mon, Jul 19, 2021 at 12:02 PM Maria Isabel Restrepo < @.***> wrote:

@.**** approved this pull request.

Left a comment in case it's helpful, but you know best!

In src/renderer/pages/Status.tsx https://github.com/brown-ccv/OmniReferenceClient/pull/107#discussion_r672431527 :

  • onClick={() => {
  • [state.left, state.right].forEach(async item => {
  • const { name } = item
  • setLeadIntegrityPending(true)
  • if (!deviceConnected(item)) { return }
  • try {
  • dispatch({ type: ActionType.IntegrityTest, name }) // NOP
  • const response = await (window as any).deviceManagerService.integrityTest({ name, leadList: integrityTestPairs() })
  • dispatch({ type: ActionType.IntegrityTestSuccess, name }) // NOP
  • } catch (e) {
  • dispatch({ type: ActionType.IntegrityTestFailure, message: e.message, name })
  • }
  • setLeadIntegrityPending(false)

Does this re-enable the the button briefly in between the left and right tests? Do you want that?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/brown-ccv/OmniReferenceClient/pull/107#pullrequestreview-709725414, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALZRKTRITFHZBKNDW6EVTN3TYRECLANCNFSM5AT42ZDA .

-- http://ccv.brown.edu/ Bradford N. Roarr https://github.com/broarr https://directory.brown.edu/uuid/0adf6ab4-8d56-410a-8ac6-4b4ca136a534

Senior Research Software Engineer Data & Visualization Center for Computation and Visualization Brown University | OIT

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 2.8.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: