Apps/Workshops: Separate linking of title from github

[mcmcgrath13]

The title should link out to the site_url (if available), the github icon should only exist if a repo_url provided (in some cases it may be private, so not part of the ready.yaml). If there is a repo_url and no site_url, the title should link to the repo.

[TiffL]

@mcmcgrath13 If there is no repo_url and no site_url, should the app/workshop still be included, just with the title not a link?

[mcmcgrath13]

I'm tempted to say there has to be at least one URL, without that the card doesn't do much... @brown-ccv/web-admin what do you think?

[mirestrepo]

hmmm - but there is always a repo because the ready.yml is inside the repo. Maybe repo_url should default to the repo being queried or be mandatory.

[mcmcgrath13]

But in some cases the repo is private, so we don't want to link to it. We could always check the private/public status, then default it if public?

On Mon, Dec 2, 2019 at 3:20 PM Maria Isabel Restrepo < notifications@github.com> wrote:

hmmm - but there is always a repo because the ready.yml is inside the repo. Maybe repo_url should default to the repo being queried or be mandatory.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brown-ccv/ccv-website/issues/120?email_source=notifications&email_token=AF53STGZUHUKVJ6UP72G77LQWVUXPA5CNFSM4JR5IIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFUYOKY#issuecomment-560564011, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF53STH7N67N3JH7LUYPZETQWVUXPANCNFSM4JR5IIVQ .

[mirestrepo]

hmmmm. maybe we change the icon for private githubs to a lock, but still link to it?

[mcmcgrath13]

I think that's more confusing since it goes to a 404 not found page if you don't have access. I vote just leave off the github icon and only link to the site_url.

On Mon, Dec 2, 2019 at 3:34 PM Maria Isabel Restrepo < notifications@github.com> wrote:

hmmmm. maybe we change the icon for private githubs to a lock, but still link to it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brown-ccv/ccv-website/issues/120?email_source=notifications&email_token=AF53STHNOSGFLUYUOD4R4Y3QWVWMJA5CNFSM4JR5IIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFUZWBY#issuecomment-560569095, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF53STD4XRWTMZ2Q6UKYI3DQWVWMJANCNFSM4JR5IIVQ .

[mirestrepo]

Sounds good to me.

[mirestrepo]

And so if private, there must be project_url.

[fernandogelin]

closing this as workshops/software are moving out of hugo