brown-ccv / ccv-website-hugo

CCV Hugo Website
https://ccv.brown.edu
5 stars 9 forks source link

docs: ✏️ Gitlab info for stronghold. Changed oscar account info #402

Closed prasadbandarkar closed 2 years ago

prasadbandarkar commented 2 years ago

Added a line describing a new feature on stronghold : Gitlab . Fixed the rates documentation for GPU priority+ Oscar account.

BREAKING CHANGE: 🧨 None

✅ Closes: None

Pull Request


PR Summary

Briefly describe the changes.

Check the types of changes present in this PR:

Checklist:

If PR to production
paulstey commented 2 years ago

Thanks, @prasadbandarkar!! This looks good to me.

Just out of curiosity, @mcmcgrath13, why didn't this build an ephemeral version of the site in Heroku? Is that Action broken?

mcmcgrath13 commented 2 years ago

looking at heroku I don't see anything obvious. I wonder if it's because the PR is from a fork instead of a branch

mcmcgrath13 commented 2 years ago

@prasadbandarkar in the future, you can/should branch off this repo instead of making a fork (and we'll see if that was the issue 🤔 )

prasadbandarkar commented 2 years ago

Can this pull request be approved today. Let me know if something else is required from my end. Thank you.