search

brown-ccv / honeycomb

Starter repo for jspsych/react/electron behavioral tasks
https://brown-ccv.github.io/honeycomb-docs/
MIT License
9 stars 8 forks source link

Remove errors with local min files? #153

Open RobertGemmaJr opened 1 year ago

RobertGemmaJr commented 1 year ago

The min files in public/lib are all returning syntax errors and I don't think they're used at all? The path in index.html isn't pointing to the correct folder.

image


    <script src="%PUBLIC_URL%/static/lib/jquery-min.js" type="text/javascript"> </script>
    <script src="%PUBLIC_URL%/static/lib/underscore-min.js" type="text/javascript"> </script>
    <script src="%PUBLIC_URL%/static/lib/backbone-min.js" type="text/javascript"> </script>
    <script src="%PUBLIC_URL%/static/lib/psiturk.js" type="text/javascript"> </script>``
`

I believe most (if not all?) now have NPM imports so I see no need to have the files locally
digicosmos86 commented 1 year ago

And we decided not to use jQuery and Backbone in the future right?

RobertGemmaJr commented 9 months ago

This has to do with using psiturk which needs the min files. They're imported differently when running in dev mode vs production (the Electron app). This may be okay to keep until v4 if/when we deprecate psiturk from Honeycomb