search

brown-ccv / honeycomb

Starter repo for jspsych/react/electron behavioral tasks
https://brown-ccv.github.io/honeycomb-docs/
MIT License
9 stars 8 forks source link

Add `p` tag to stimulus in the introduction trial #487

Closed RobertGemmaJr closed 2 months ago

RobertGemmaJr commented 3 months ago

What other trials are missing an html tag?

RobertGemmaJr commented 3 months ago

@YUUU23 The introduction trial can be found at src/experiment/introduction. Note the p function in src/lib/markup/tags.

These functions were added to make the creation of HTML strings easier, which is a unique challenge of working with jsPsych. Do some digging to see how jsPsych uses the HTML strings and what those tag functions do. Happy to answer any questions! The issue itself is just that the introduction trial is not using the p function. Can you see what changes when you add it?

YUUU23 commented 3 months ago

@RobertGemmaJr

I noticed that the original introduction stimulus uses h1 instead of p, which makes the introduction text a large heading instead of a regular text, assuming the latter is what is preferred. I've created a PR to refactor this; if you can take a look when you have time that would be really appreciated!

Thanks!