rm bootstrap - Githubissues

brown-ccv / honeycomb

Starter repo for jspsych/react/electron behavioral tasks

https://brown-ccv.github.io/honeycomb-docs/

MIT License

9 stars 8 forks source link

rm bootstrap #512

Closed YUUU23 closed 2 months ago

YUUU23 commented 2 months ago

In Login.jsx:

refactor form and button to use vanilla HTML + CSS (styling may not be exactly like bootstrap styling, but should be very similar); all new CSS added in place of the bootstrap styling is in index.css
remove all related bootstrap imports (also removed in App.jsx)

In Camera.js;

remove centering camera bootstrap classes and added CSS to simply center those elements when setting up and ending camera

Change alert alert-danger to alert-danger CSS class with similar styling as bootstrap's alert-danger class

github-actions[bot] commented 2 months ago

Visit the preview URL for this PR (updated for commit 9082577):

https://ccv-honeycomb--pr512-rm-bootstrap-gx5nphdh.web.app

_{(expires Wed, 31 Jul 2024 19:34:32 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610}

YUUU23 commented 2 months ago

Should I remove the boostrap dependency manually from package.json or does it get automatically removed when rebuilding we do not use bootstrap anywhere?

RobertGemmaJr commented 2 months ago

Should I remove the boostrap dependency manually from package.json or does it get automatically removed when rebuilding we do not use bootstrap anywhere?

You'll have to remove it manually! You can run npm uninstall bootstrap react-bootstrap to uninstall the dependencies

YUUU23 commented 2 months ago

Fantastic! Just uninstall the dependencies we no longer need and this will be good to go!

Just made this change! Would you be able to check one more time if everything looks good? Thanks!