search

brown-ccv / icesat2waves

ICESat-2 track analysis
GNU General Public License v3.0
0 stars 2 forks source link

chore: logging 5 - remove prints from local_modules directory #179

Closed hollandjg closed 3 months ago

hollandjg commented 4 months ago

Builds on

resolves #196

hollandjg commented 4 months ago

If they are kept and used later, extra work would be needed to make the messages lazily evaluated.

I agree. A lot of these lines are also touched in #131 (and a lot will be removed), so I don't want to make all the corrections just yet. Once we see what the final merge looks like we can revisit here.

I'm also mindful of the extra effort going through and fixing commented out code might add, and I feel like we're close to the point of diminishing returns here. (There's a strong argument that we hit that point two weeks ago when you said this would be too much work – it's been more work than I expected.)