search

brown-ccv / jupyterhub-docker-images

GNU General Public License v3.0
0 stars 1 forks source link

NEUR1630 Github Dependency #105

Open anna-murphy opened 1 month ago

anna-murphy commented 1 month ago

Adds git+https://github.com/alleninstitute/abc_atlas_access.git as a dependency in requirements.txt for the NEUR1630 image.

anna-murphy commented 1 month ago

@digicosmos86 Might need to call in some help on this one... I've added the appropriate line to the requirements.txt file, but it looks like it can't find the repository when building it in the github action. If I do it locally, I can install it however.

$ python3 -m venv .venv
$ source .venv/bin/activate
$ pip -U install git+https://github.com/alleninstitute/abc_atlas_access.git

I also know that you can install through a requirements.txt like this because it's how I wrote the TC Cloud Model package. Any thoughts why the Github Action runner wouldn't be able to find this?

digicosmos86 commented 1 month ago

@digicosmos86 Might need to call in some help on this one... I've added the appropriate line to the requirements.txt file, but it looks like it can't find the repository when building it in the github action. If I do it locally, I can install it however.

$ python3 -m venv .venv
$ source .venv/bin/activate
$ pip -U install git+https://github.com/alleninstitute/abc_atlas_access.git

I also know that you can install through a requirements.txt like this because it's how I wrote the TC Cloud Model package. Any thoughts why the Github Action runner wouldn't be able to find this?

Okay it's because the requirement.txt is actually installed by conda/mamba, which do not support installing from git. Looking for solutions, Hold on a sec

digicosmos86 commented 1 month ago

Oh @anna-murphy you can actually add it to requirements.pip.txt, and then the package will be installed with pip. Let me know if this works

anna-murphy commented 1 month ago

Good catch! This is good to merge whenever~