search

brown-ccv / jupyterhub-docker-images

GNU General Public License v3.0
0 stars 1 forks source link

Use the same environment variables all builds #29

Open mirestrepo opened 3 years ago

mirestrepo commented 3 years ago

I noticed that the python builds are happening with COMPOSE_DOCKER_CLI_BUILD=1 DOCKER_BUILDKIT=1, but not the julia builds. Should we be using the same environment variables for both?

_Originally posted by @broarr in https://github.com/brown-ccv/jupyterhub-docker-images/pull/26#discussion_r554128135_

mirestrepo commented 3 years ago

@fernandogelin Is there a reason you didn't use the build-kit for the Julia target?

fernandogelin commented 3 years ago

@mirestrepo humm I don't think there's a reason, I probably didn't change the julia builds when I started using build kit..

mirestrepo commented 3 years ago

To do