brown-ccv / jupyterhub-docker-images

GNU General Public License v3.0
0 stars 1 forks source link

Need to separate production build from testing build #6

Closed mirestrepo closed 4 years ago

mirestrepo commented 4 years ago

In production, classes will have sesonal tags, let say apma0360:fall2020. I think building the seasonal tag should only happen on PR merge to the main branch to make sure any change to production undergoes a review. On push to feature branches we should build REF and latest1 ... @fernandogelin had the second step... @mirestrepo added the seasonal tag, but this is a reminder to switch it only to production workflow. My fear is that a change at the higher level lets sayscripts` could trigger automatically all production images to rebuild, which should only happen if we have confirmed behavior