check texture sizes should be optional (on by default)

brown-ccv / react-volume-viewer

Volume Viewer package for react based websites

MIT License

0 stars 0 forks source link

check texture sizes should be optional (on by default) #134

Closed kmilo9999 closed 2 years ago

kmilo9999 commented 2 years ago

Blending two datasets of different number of slices throws an error due to texture sizes restrictions. This should be optional in the library in case we find this cases. related to #113

RobertGemmaJr commented 2 years ago

I'm not sure what you want me to implement. Right now they always have to be the same size. We would have to calculate the start and end position for each individual model again in order for this to work, which is fine if that's what you're looking for

kmilo9999 commented 2 years ago

It should be possible to blend multiple datasets with different sizes. Right now, it throws an error when the volumes have a different width and height. Could you remove this check and/or make it optional?