search

brown-puzzle-hq / bph-site

1 stars 0 forks source link

Hide HintForm in Dialog #140

Open brian-xu opened 2 weeks ago

brian-xu commented 2 weeks ago

UI is subject to change, but I think it looks fine.

This PR is subject to the bug described in #139.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bph-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 4:50am
qiaochloe commented 1 week ago

Looks good! I like the look of the dialog pop-up (and we should use it in more places), but I wonder if tabs might be more cohesive here? We can have one for "hinting," "solutions," and "stats" in the future. I won't get around to it anytime soon, so I'm happy to accept this PR for Puzzlethon.

alex-j-wang commented 1 week ago

@qiaochloe can you make cursor initialize at the end of the text when reopening the dialog? 👉👈

brian-xu commented 1 week ago

For some reason the hint button now shows up at the top of my screen? I don't really have an issue with it but I also don't understand why it moved.

alex-j-wang commented 1 week ago
image

It's at the bottom for me.

alex-j-wang commented 1 week ago

Separate hint pages are more typical so going to convert this to draft. Dialog might be useful for stuff in the future though.