Closed longlene closed 4 years ago
Hello. Thanks for uploading some commits. Last weekend I also ported protobuf to release 3.6.1 of the Google compiler, but I have not yet pushed the changes. I'll do so tonight and also take a look at your changes. Thanks again.
Bob
On Wed, Sep 27, 2017 at 7:28 AM longlene notifications@github.com wrote:
namespace required
You can view, comment on, or merge this pull request online at:
https://github.com/brown/protobuf/pull/11 Commit Summary
- compile error fix
File Changes
- M protoc/lisp/Makefile https://github.com/brown/protobuf/pull/11/files#diff-0 (2)
- M protoc/lisp/enum.cc https://github.com/brown/protobuf/pull/11/files#diff-1 (6)
- M protoc/lisp/enum_field.cc https://github.com/brown/protobuf/pull/11/files#diff-2 (2)
- M protoc/lisp/enum_field.h https://github.com/brown/protobuf/pull/11/files#diff-3 (4)
- M protoc/lisp/message.cc https://github.com/brown/protobuf/pull/11/files#diff-4 (10)
- M protoc/lisp/message_field.cc https://github.com/brown/protobuf/pull/11/files#diff-5 (2)
- M protoc/lisp/message_field.h https://github.com/brown/protobuf/pull/11/files#diff-6 (4)
- M protoc/lisp/primitive_field.cc https://github.com/brown/protobuf/pull/11/files#diff-7 (2)
- M protoc/lisp/primitive_field.h https://github.com/brown/protobuf/pull/11/files#diff-8 (4)
- M protoc/lisp/service.cc https://github.com/brown/protobuf/pull/11/files#diff-9 (10)
- M protoc/lisp/service.h https://github.com/brown/protobuf/pull/11/files#diff-10 (2)
- M protoc/lisp/string_field.cc https://github.com/brown/protobuf/pull/11/files#diff-11 (2)
- M protoc/lisp/string_field.h https://github.com/brown/protobuf/pull/11/files#diff-12 (4)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/brown/protobuf/pull/11, or mute the thread https://github.com/notifications/unsubscribe-auth/AABqse_a6y59PRJ5uwEmeYIm7BulIGHoks5smjFPgaJpZM4Plnfg .
I just built it for C++11, fixed the build error, not change too much. You can just push your's changes. :-)
I just pushed my recent protobuf 3.6.1 changes to github. Please take a look and let me know if they work for you.
On Fri, Nov 30, 2018 at 2:13 AM longlene notifications@github.com wrote:
I just built it for C++11, fixed the build error, not change too much. You can just push your's changes. :-)
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brown/protobuf/pull/11#issuecomment-443113310, or mute the thread https://github.com/notifications/unsubscribe-auth/AABqsVhV6OIW5dLA1gfnp_JxqaUyQZR-ks5u0NqFgaJpZM4Plnfg .
I just applied a bunch of more recent patches, so I think this request is now obsolete. Thanks very much for your fixes.
namespace required