search

brownbat / autoEaseFactor

Adjust ease factors in Anki based off of performance in order to hit a target success rate.
GNU General Public License v3.0
37 stars 8 forks source link

issue where cards intervals are getting distorted when you hit undo #55

Open clubmeh opened 3 years ago

clubmeh commented 3 years ago

Hi,

I've noticed this on many occasions, but sometimes when I hit undo on a card to quickly re-read something in the extra section, I have noticed that had I pressed on the card prior to undo, the bonus ease does not get reversed. This results in the second pressing of good / pass to have a massively increased interval (had a card I undid that had an interval of 3.0 months go to 4.4 months b/c of this bug).

If this is really how it is functioning for everyone this is a critical issue that needs to be fixed.

jazzyjangles commented 3 years ago

hey i am a user not the author and stumbled upon this and looked into it a little myself. are u using the browser to check the interval or are u using the card reviewer when it says the interval above the answer choice? use the browser. because what i noticed is when doing undo/review undo/review over and over pressing different buttons the ease is set accuratley to the most recent press. ie when i press good and the ease goes from 300 to 330... when i press undo it shows 330 still.. but then if i press again it sets the ease to 280. now if i press undo it says the ease is 280, but if i press good it corrects and schedules it for the ease of 330. so what im saying is my scheduler is working properly even if i press undo. its just that when i press undo it doesnt correct the ease until after i rate good/again. but when i see a card for the first time without doing undo it would set it to 280 or 330 depending on what i rate it so the ease is correcting fine for me.

brownbat commented 3 years ago

The interval hints above the buttons assume the standard algorithm, so they are really misleading and don't reflect the actual ease / interval of the card as seen in the browser after the review.

I'll take another look at this one, but in the past when it came up, it was a problem with the predicted interval that Anki displays on the cards not realizing we're going to alter the ease before its calculation is complete.

AustinHasten commented 2 years ago

Sometimes (not always?) the card's factor doesn't seem to get reset on undo. This can cause confusion if you look at the card's info pane and probably accounts for the wacky predicted intervals. It shouldn't actually affect the addon's behavior because the addon gets a card's current factor by looking at the most recent review, not the actual factor on the card at the time.