search

browngraphicslab / Dash-Web

Other
1 stars 0 forks source link

why is facet filter no longer part of search, but a separate component? #779

Open melissa-z opened 4 years ago

melissa-z commented 4 years ago

When I want to filter content in my document, my first instinct is to search for the keyword/field in the search bar. I was just wondering why facet filters are now a separate component that seems to be completely unrelated to search? I also much preferred the search UI when filtering on specific fields.

bobzel commented 4 years ago

There are various scenarios for filtering which would benefit differently from alternative UIs.

The topbar filter could do somet things the sidebar filter couldn't and vice-versa. However, the sidebar filter is simpler and worked better in terms of performance, UI robustness and functional consistency. Having both filtering mechanisms caused conflits because of the mismatch in functionality and was confusing.

To get V1 off the ground, one of them had to be turned off.

For V2, we should restore both forms of filtering by making the left sidebar more expressive while fixing the implementation problems of the topbar filter.

melissa-z commented 4 years ago

That makes a lot of sense! Thank you for the explanation.