search

browngraphicslab / tag

Touch Art Gallery is an app that allows museum visitors to explore art using familiar touch gestures. This is the codebase for the TAG web application.
0 stars 0 forks source link

Demo server content update #160

Closed bleveque closed 10 years ago

bleveque commented 10 years ago

Update the metadata for artworks on the demo server. This metadata should be accurate and informative, since it is meant to be browsed by people who install TAG.

bleveque commented 10 years ago

@JessicaFu anything we should add?

JessicaFu commented 10 years ago

Musical Allegory in the Rembrandt collection seems to be missing a thumbnail.

JessicaFu commented 10 years ago

Nevermind it's back...which is weird.

bleveque commented 10 years ago

Alright, that's strange -- anything other than that?

JessicaFu commented 10 years ago

-The universal scroll has an unknown author and so does Four studies of a Male Head in the Getty museum collection. But when you sort by artist, the scroll shows Unknown while the artwork about the male head shows a blank artist at the top of its thumbnail. The same thing is happening in the HIAA collection.

-The contributor's list could be updated

bleveque commented 10 years ago

It looks like the default value of the #artistInfo div is "Unknown" if the artist metadata property is empty:

artistInfo.text("Artist: " + (artwork.Metadata.Artist || "Unknown"));

while I guess the artist displayed when sorting doesn't have a default.

Do you mean the list of people who've worked on TAG?

JessicaFu commented 10 years ago

We should make the artworks when sorted by artist uniform for all artworks with no artists.

Yep

bleveque commented 10 years ago

I think the universal scroll's artist is actually listed as "Unknown" -- that just happens to be what the default is in #artistInfo as well. I agree that the sort value should be consistent with what is in #artistInfo, though.

JessicaFu commented 10 years ago

Oh I see. That's fine then.

bleveque commented 10 years ago

The list of contributors is actually in our code rather than being something set on the server. Maybe we should add this to the release 2.0 notes... Can this one be closed?

JessicaFu commented 10 years ago

Yep! Otherwise, this looks good.