Some issues in authoring with new collections page

browngraphicslab / tag

Touch Art Gallery is an app that allows museum visitors to explore art using familiar touch gestures. This is the codebase for the TAG web application.

0 stars 0 forks source link

Some issues in authoring with new collections page #166

Closed lucyvk closed 9 years ago

lucyvk commented 10 years ago

Collection viewer gets confused when trying to display the preview of an unpublished collection because only published collections get a 'collectionDot' saved, so it isn't sure which collection dot to highlight
width and height of timeline event circles is hard-coded at 20px, so they look disproportionally large in the collection preview viewer

JessicaFu commented 10 years ago

@karthikhhr Can you take a look at this issue?

JessicaFu commented 10 years ago

I think all the relevant code is in TAG Core now in TAG.Layout.CollectionsPage.js

bleveque commented 10 years ago

@EmilyReif, mentioning you so there isn't overlap between what you and @karthikhhr work on

JessicaFu commented 10 years ago

The preview window doesn't load at all for unpublished collections.

lucyvk commented 10 years ago

I think this has to do with the preview of the collections page not knowing what collection dot to highlight, because the collection it is trying to preview does not have a dot made. You might be able to just override this in the collections page so that if the current collection isn't in the list of published collections, you just add a collection dot to the beggining of the list and highlight it.

On Tue, Jul 29, 2014 at 10:26 AM, Jessica Fu notifications@github.com wrote:

The preview window doesn't load at all for unpublished collections.

— Reply to this email directly or view it on GitHub https://github.com/browngraphicslab/tag/issues/166#issuecomment-50482554 .

bleveque commented 10 years ago

@karthikhhr also, the "collection preview image" option should be removed from settings view, since the preview image isn't displayed anywhere anymore

JessicaFu commented 10 years ago

@karthikhhr The collectionDot issue is actually crashing the Win8 version of TAG

lucyvk commented 10 years ago

Going to take this on because it is crashing win8 and making it hard to test.

lucyvk commented 10 years ago

Think this is all set @tanaypadhi I think you mentioned this issue at some point. Could you review?

lucyvk commented 9 years ago

outdated