collections page arrows and titles should be added to DOM

browngraphicslab / tag

Touch Art Gallery is an app that allows museum visitors to explore art using familiar touch gestures. This is the codebase for the TAG web application.

0 stars 0 forks source link

collections page arrows and titles should be added to DOM #176

Closed lucyvk closed 10 years ago

lucyvk commented 10 years ago

Instead of being re-created and re-appended each time the collection switches, the text and associations to the next and previous collection should change but the divs themselves for the nextPrevCollections, the mainCollection, the backArrowArea, and the nextArrowArea should not be deleted and then recreated.

JessicaFu commented 10 years ago

@qingyunwan Could you take a look at this when you come back?

bleveque commented 10 years ago

They could be created in the jade file

bleveque commented 10 years ago

Low priority for Aug15

qingyunwan commented 10 years ago

@lucyvk Fixed it! Please review ~~~^ ^

JessicaFu commented 10 years ago

@lucyvk Can you review please?

lucyvk commented 10 years ago

Looks good! One thing I noticed is that the styling for collections titles of previewed un-published collections in authoring mode is a little off: There is a 'previewing' boolean in the Collections Page that you can use for previewing-specific style fixes.

qingyunwan commented 10 years ago

I will look at it ^_^

qingyunwan commented 10 years ago

Fixed it! O(∩_∩)O

JessicaFu commented 10 years ago

@lucyvk Can you review?

JessicaFu commented 10 years ago

Looks good! Imma close this Lucy