Closed JessicaFu closed 9 years ago
@JessicaFu should be done. @surbhimadan1995 , wanna review? :dancers:
@EmilyReif , please add the scroll arrows instead of the scrollbar :dancer: :dancer:
@surbhimadan1995 , added!
Just checking, is there still supposed to be a scrollbar ? Also, the left arrow is a little to much into the edge .. (win8)
This is an assoc media preview but it doesn't seem to have a thumbnail image for the artwork associated to it (although we know the thumbnail exists).
@lucyvk Can you take over this issue?
@JessicaFu How do you think we should handle audio thumbnails? Just have the icon take up the whole thumbnail box?
I think so. What do you think?
Yea I think so, not sure what alternative there would be.
On Sat, Aug 9, 2014 at 8:37 PM, Jessica Fu notifications@github.com wrote:
I think so. What do you think?
— Reply to this email directly or view it on GitHub https://github.com/browngraphicslab/tag/issues/190#issuecomment-51702543 .
Previewer seems too big for no timeline mode
Added cancel x: But, unsure how to handle for multiple preview windows-- for now I just have it only appending to first preview window (it might be confusing to have mutliple x's that all close the entire preview window), however, when you scroll along the previewer the x scrolls with the first preview tile. Unfortunately, it gets covered by the preview tiles if you just append it to the entire preview window, so that is not an option. @jesspherron, thoughts?
Can you increase the z-index of the x button if you append it to the entire preview window?
I don't think so because the selected artwork container already has a z-index set and elements take on the z-index of their parents
The scroll bar still appears. Can that be removed?
no arrows for some reason
why is this loading circle not going away?
All these should be done-- any other issues with the previewer have been listed else where. @tanaypadhi can you review preview styling as you are fixing up the collections page?
addressed at this point
Changes to the previewer according to Jess' spec (Asset Timeline png files)
Also add the following: -Make the asset previewer bigger and add scroll arrows on the sides to scroll through the list of associated media/artworks on the bottom of the previewer (instead of using a scroll bar). -Artist, title, year fields should be constrained with "..." if they are too long -Move Artist and Year fields to the bottom of the preview image so that the previewer kind of looks like this: Title [ ] Artist Year