browngraphicslab / tag

Touch Art Gallery is an app that allows museum visitors to explore art using familiar touch gestures. This is the codebase for the TAG web application.
0 stars 0 forks source link

Changes to artwork /assoc media previewer #190

Closed JessicaFu closed 9 years ago

JessicaFu commented 10 years ago

Changes to the previewer according to Jess' spec (Asset Timeline png files)

Also add the following: -Make the asset previewer bigger and add scroll arrows on the sides to scroll through the list of associated media/artworks on the bottom of the previewer (instead of using a scroll bar). -Artist, title, year fields should be constrained with "..." if they are too long -Move Artist and Year fields to the bottom of the preview image so that the previewer kind of looks like this: Title [ ] Artist Year

EmilyReif commented 10 years ago

@JessicaFu should be done. @surbhimadan1995 , wanna review? :dancers:

surbhimadan1995 commented 10 years ago

@EmilyReif , please add the scroll arrows instead of the scrollbar :dancer: :dancer:

EmilyReif commented 10 years ago

@surbhimadan1995 , added!

surbhimadan1995 commented 10 years ago

screenshot 5

surbhimadan1995 commented 10 years ago

Just checking, is there still supposed to be a scrollbar ? Also, the left arrow is a little to much into the edge .. (win8)

JessicaFu commented 10 years ago

image

This is an assoc media preview but it doesn't seem to have a thumbnail image for the artwork associated to it (although we know the thumbnail exists).

JessicaFu commented 10 years ago

@lucyvk Can you take over this issue?

lucyvk commented 10 years ago
lucyvk commented 10 years ago
lucyvk commented 10 years ago

@JessicaFu How do you think we should handle audio thumbnails? Just have the icon take up the whole thumbnail box?

screenshot 62

JessicaFu commented 10 years ago

I think so. What do you think?

lucyvk commented 10 years ago

Yea I think so, not sure what alternative there would be.

On Sat, Aug 9, 2014 at 8:37 PM, Jessica Fu notifications@github.com wrote:

I think so. What do you think?

— Reply to this email directly or view it on GitHub https://github.com/browngraphicslab/tag/issues/190#issuecomment-51702543 .

lucyvk commented 10 years ago

Previewer seems too big for no timeline mode screenshot 64

lucyvk commented 10 years ago

Added cancel x: screenshot 65 But, unsure how to handle for multiple preview windows-- for now I just have it only appending to first preview window (it might be confusing to have mutliple x's that all close the entire preview window), however, when you scroll along the previewer the x scrolls with the first preview tile. Unfortunately, it gets covered by the preview tiles if you just append it to the entire preview window, so that is not an option. @jesspherron, thoughts? screenshot 67

JessicaFu commented 10 years ago

Can you increase the z-index of the x button if you append it to the entire preview window?

lucyvk commented 10 years ago

I don't think so because the selected artwork container already has a z-index set and elements take on the z-index of their parents

JessicaFu commented 10 years ago

The scroll bar still appears. Can that be removed? image

lucyvk commented 10 years ago

image no arrows for some reason

lucyvk commented 10 years ago

image why is this loading circle not going away?

lucyvk commented 10 years ago

All these should be done-- any other issues with the previewer have been listed else where. @tanaypadhi can you review preview styling as you are fixing up the collections page?

lucyvk commented 9 years ago

addressed at this point