Deal with loading artworks/assoc media when toggling between artwork and assoc media timeline

browngraphicslab / tag

Touch Art Gallery is an app that allows museum visitors to explore art using familiar touch gestures. This is the codebase for the TAG web application.

0 stars 0 forks source link

Deal with loading artworks/assoc media when toggling between artwork and assoc media timeline #197

Closed JessicaFu closed 9 years ago

JessicaFu commented 10 years ago

@lucyvk Since you know the timeline code a bit better. :)

JessicaFu commented 10 years ago

(this is assoc media view) -highlight the correct toggle between artworks and assoc media -highlight the correct sort tag (default should be title if timeline is not enabled, otherwise it should be Date)

JessicaFu commented 10 years ago

This is what I mean by various thumbnails don't load.

Also you were using .getAssocMediaTo which gets assoc media to an artwork. You should be using .getAssocMediaIn. I pushed the changes already so let me know if it's correct!

JessicaFu commented 10 years ago

-Assoc media toggle should default to Title and Date sort labels

lucyvk commented 10 years ago

Oh duh! I was using the correct function on the monitor in the lab but I must have messed it up when I quickly copied it on my laptop to test! Yay I'm glad it's working! I will look into the thumbnail issue. For now it should be defaulting to Title and Date for associated media view but I will test more if that isn't working for some reason.

On Aug 8, 2014, at 10:13 PM, Jessica Fu notifications@github.com wrote:

This is what I mean by various thumbnails don't load.

Also you were using .getAssocMediaTo which gets assoc media to an artwork. You should be using .getAssocMediaIn. I pushed the changes already so let me know if it's correct!

— Reply to this email directly or view it on GitHub.

lucyvk commented 10 years ago

Artwork viewer, video player, tour player should remember that we were in associated media view, not artwork view and go back there.

lucyvk commented 10 years ago

There are some random errors when going from an associated media previewer into an artwork, looks like it usually happens with hotspots (viewer isn't defined)- It's been hard for me to reproduce, though
Errors going back to collections page from the viewer if you close the hotspot that you went into the viewer from

lucyvk commented 10 years ago

We are all set on above except for the one bug that I found when opening artworks to a specific hotspot and then immediately panning to their hotspot position. This works 95% of the time, but I got about 4 errors from this where the seadragon viewer wasn't defined. This seems strange because the call isn't made until after the annotated image has loaded all of the associated media (which doesn't happen until after it is initialized, which includes initialization of the viewer....)

@JessicaFu I had this error happen on the test server going from the artwork !!! 5_Adorationshep to the whole foods parking lot video hotspot in the No Timeline? collection. Also, in the collection Boo the Dog, the 'Untitled' associated media that has a thumbnail of 4 women (kpop??). So yeah, let me know if you can reproduce these! thanks!

lucyvk commented 9 years ago

addressed at this point