Add Iframe UI around the functionality

[JessicaFu]

Iframe assoc media functionality is already in place.

UI Changes a) in assoc media tab in authoring, move the import button underneath the search bar [SEARCH BAR] [Embed] [Import] .....assets.... ..... -the Embed button should pop up the message box and overlay already implemented

c) If the iframe doesn't load its asset in 10sec, display a warning message: "Error loading embeded asset" Set a timeout for 10sec to display the error message in the viewer but when .load (callback)'s callback gets called, clear the timeout.

[JessicaFu]

@tanaypadhi Can you take a look at that?

[JessicaFu]

Right now the iframe title is set to be the url of the webpage. Should we instead give it a title and add the url as the source? The url shouldn't be shown in artwork viewer though.

[JessicaFu]

NEW: drop down menu from [ADD] button (current import) in assoc media tab that would reveal [From File] and [Embed Video]

[JessicaFu]

@davidtweinberger Can you take a look?

[JessicaFu]

@davidtweinberger Have you had a chance to work on this yet? If not, @tanaypadhi do you mind taking over?

[davidtweinberger]

Yeah, it's basically done, I haven't marked it for review because I haven't tested it in the web app

On Aug 8, 2014, at 22:42, Jessica Fu notifications@github.com wrote:

@davidtweinberger Have you had a chance to work on this yet? If not, @tanaypadhi do you mind taking over?

\ Reply to this email directly or view it on GitHub.

[JessicaFu]

Awesome! :+1:

[tanaypadhi]

Just saw it (and then stumbled on the issue). It looks great! Just one thing, right now if you scroll, the scroll bar partially covers the menu. Could you fix that? Should be just a z-index thing.

[JessicaFu]

-Can you change the css of the drop down to match the css of the import buttons in other views

[tanaypadhi]

Hey @davidtweinberger, the menu options don't seem to be working for me (i.e. clicking on the drop-downs aren't opening the relevant dialogs). Once we're done with that and the small styling edits, we're good to go.

[JessicaFu]

Fixed! This has to do with javascript event bubbling (can ask me Monday). The styling needs to be fixed though.

[JessicaFu]

-when you navigate away from a page, the drop down menu doesn't close. You could try to hide the drop down menu in prepareNextView and loadAssocMedia

[JessicaFu]

@davidtweinberger -center the arrow on the "Add" button

[JessicaFu]

-arrow should be black -the scroll bar should not be in front of the picker

[davidtweinberger]

OK. i think this is finally fixed.

[davidtweinberger]

i'm not sure why the scrollbar was in front of the dropdown? so i just hid it when the dropdown is open and that seemed to work

[lucyvk]

At this point, only supporting embedded videos, so closing