Closed bleveque closed 10 years ago
@JessicaFu can you get @EmilyReif up to speed on this one?
Never mind! Reassigned to @jlgithu
@jlgithu status?
pushed changes for this issue, auto-linking is applied to descriptions in new catalog and artmode but is easily extendible to any other texts
@JessicaFu can you review this?
Add hyperlinking for descriptions of individual artworks.
@JessicaFu changes pushed
Maybe add link capabilities on the splash page description as well? It would be useful if people want to direct users to the museum main page or something. What do you think? Otherwise, it looks good!
Sounds good -- @jlgithu can you add this in?
Well clicking on the splash screen will take users to the collections view, therefore if users click on a link in splash screen they will first visit the linked webpage and come back to tag finding themselves in a different view. It might be a bit confusing. Do you guys still think it's good to add it now? Or maybe change a bit of code in splash screen so that it doesn't go over to the collections view when a linked is clicked?
You can try e.stopPropagation() whenever a link is pressed.
I'll need to look more in to the code in the Autolinker package for that. I don't have enough time to work on this tonight, but'll get this done asap
Okay, splash screen links aren't crucial for codefreeze
@jlgithu is this ready for review?
added link capabilities to the museum description in splash screen, should be ready for review
Great, is there an existing example, or should I just add a link via authoring?
I don't think there are any examples, so you'll need to add a link via authoring, or just append links to the string on the client side.
Works well! The only issue I see is that it's pretty hard to read the link text against some backgrounds (first screenshot). @jesspherron any suggestions? Could we add a slight background (second screenshot -- link tag has a background-color of rgba(0,0,0,0.4) and border-radius of 5px)?
yes, I'd say instead of doing the very 90s underlined blue, we have the link be gray, with no underline. then if the user hovers over it, it can turn white, and they know it's interactive. also, don't put it on the same line in parenthesis, put it like this:
Created by the Brown University Graphics Group cs.brown.edu/research/ptc/tag http://cs.brown.edu/research/ptc/tag
like that.
On Mon, Apr 28, 2014 at 2:01 AM, Benjamin LeVeque notifications@github.comwrote:
Works well! The only issue I see is that it's pretty hard to read the link text against some backgrounds (first screenshot). @jesspherronhttps://github.com/jesspherronany suggestions? Could we add a slight background (second screenshot -- link tag has a background-color of rgba(0,0,0,0.4) and border-radius of 5px)?
[image: screen shot 2014-04-28 at 1 57 23 am]https://cloud.githubusercontent.com/assets/1434349/2813852/0638d494-ce9a-11e3-91ee-39507a7d8cfc.png
[image: screen shot 2014-04-28 at 1 59 49 am]https://cloud.githubusercontent.com/assets/1434349/2813863/710b03b4-ce9a-11e3-827e-1a99f357e64f.png
— Reply to this email directly or view it on GitHubhttps://github.com/browngraphicslab/tag/issues/23#issuecomment-41525507 .
@jlgithu any updates on this one?
Should the ui implementation to accommodate the easy creation of links on authoring side be a future feature? Has this been requested lately?
I think how it works now is that links are automatically recognized by the Autolinker library.
@jesspherron and @JessicaFu can you review? The current behavior is that link text shows up white and then is underlined on hover:
Before hover:
On hover:
That seems like good behavior to me. Do you want us to review that, or to test it for bugs or something?
On Fri, Jun 6, 2014 at 10:27 AM, Benjamin LeVeque notifications@github.com wrote:
@jesspherron https://github.com/jesspherron and @JessicaFu https://github.com/JessicaFu can you review? The current behavior is that link text shows up white and then is underlined on hover:
Before hover: [image: screen shot 2014-06-06 at 10 26 57 am] https://cloud.githubusercontent.com/assets/1434349/3201327/ae24a1d2-ed86-11e3-8836-bd290fa324a2.png
On hover: [image: screen shot 2014-06-06 at 10 27 05 am] https://cloud.githubusercontent.com/assets/1434349/3201331/b292f3cc-ed86-11e3-84d1-f1ef94e73207.png
— Reply to this email directly or view it on GitHub https://github.com/browngraphicslab/tag/issues/23#issuecomment-45342432.
Jess F can do a quick review for bugs, but I think the styling was the main issue remaining.
We talked about a possible ui for that (gmail linking style) but I don't think it was ever implemented.
Ah right, so you could have non-URL text as a link? I think that would be nice, but we haven't had requests for it, so I'd say we put that on the back burner and create a separate issue later if necessary.
@JessicaFu can this one be closed?
Looks good!
We should give curators a way to include links to online content (e.g., the RISD museum wants to include links to their website in associated media descriptions), but the links should only be active in the web app. In the win8 app, it would be too confusing (and undesirable) for the visitor to click on a link and be taken away from the app and into the browser. So when we display any text that could contain links (mostly descriptions), we should run it through a helper function that decides whether the app is being run in Metro or in the browser (http://stackoverflow.com/questions/8462896/how-to-detect-win8-metro-from-javascript) and then displays any links in the text accordingly. If it's in Metro, probably just the url should be displayed, so the .....' should be cut out.
After that, we'll have to give curators an easy way to create links in the win8 authoring mode. We could probably emulate the gmail compose window.