search

brownhci / WebGazer

WebGazer.js: Scalable Webcam EyeTracking Using User Interactions
https://webgazer.cs.brown.edu
Other
3.54k stars 536 forks source link

Install dependencies and rebuild dist on relevant githooks #168

Closed Skylion007 closed 4 years ago

Skylion007 commented 4 years ago

This should finally remove the need to have compiled versions of WebGazer ready to go. This way after running npm install in the root folder, it should automatically run githooks to update all the dependencies and build dist and copy the built ones to www.

Should solve #156 partially and ensure that dist always corresponds to the latest version.

This should also be the last step we need to deploy on npm since it fixes the bug where our "files" we were using were not correct.

jeffhuang commented 4 years ago

Overall it works, and thanks Aaron for doing this. Kind of neat to have it build when you git pull, and I was thinking of a case where maybe this is undesirable, but since the developer needs to npm install first before anything triggers, it's probably fine. It makes things a bit more fragile, but not a big deal.

The only change I'd suggest is having the minimized version be the one put on www/ (I think for the longest time, the download version was indeed a minimized version anyways), rather than the regular one. Just a tiny tweak, but curious if that makes sense (and we can refer people to that version when they click "Download WebGazer.js" on the main page as well.

Skylion007 commented 4 years ago

I think linking to the minified version can be a separate PR.