Closed hanadi92 closed 2 years ago
This line of code makes the videoElement a child of the videoContainerElement: https://github.com/brownhci/WebGazer/blob/966b1c149575871e4021bcca8a2d90760d122622/src/index.mjs#L556 And this line of code is called inwebgazer.end(): https://github.com/brownhci/WebGazer/blob/966b1c149575871e4021bcca8a2d90760d122622/src/index.mjs#L707 Removing the videoElementas if it is a child of the document.body is causing a JavaScript error. Therefore, I fixed the issue in this pull-request by removing the videoContainerElement in webgazer.end() since it's created on webgazer.begin() and holds the videoElement and the videoElementCanvas.
videoElement
videoContainerElement
webgazer.end()
document.body
webgazer.begin()
videoElementCanvas
lgtm, thanks
This line of code makes the
videoElement
a child of thevideoContainerElement
: https://github.com/brownhci/WebGazer/blob/966b1c149575871e4021bcca8a2d90760d122622/src/index.mjs#L556 And this line of code is called inwebgazer.end()
: https://github.com/brownhci/WebGazer/blob/966b1c149575871e4021bcca8a2d90760d122622/src/index.mjs#L707 Removing thevideoElement
as if it is a child of thedocument.body
is causing a JavaScript error. Therefore, I fixed the issue in this pull-request by removing thevideoContainerElement
inwebgazer.end()
since it's created onwebgazer.begin()
and holds thevideoElement
and thevideoElementCanvas
.