search

brownhci / WebGazer

WebGazer.js: Scalable Webcam EyeTracking Using User Interactions
https://webgazer.cs.brown.edu
Other
3.54k stars 536 forks source link

Add .mjs to all relative imports #321

Closed revosw closed 1 year ago

revosw commented 1 year ago

Fixes #320

jeffhuang commented 1 year ago

Thanks for the PR. I'm usually a bit nervous about these changes, because they sometimes break a build in another person's environment or when used with another framework. So if you don't mind, I'll leave this PR here, and wait for a while to see if we can get more testers.

Aenimus commented 1 year ago

Hi @jeffhuang we understand your concerns. Thank you for the reply. 🙏

However, do you have any suggestions on how to proceed? @Apoorv012 @revosw and I all ran into this issue, as did the folks over in https://github.com/brownhci/WebGazer/pull/321

We are using a workaround by creating a fork and importing the fork through npm.

In addition, at what point would you feel comfortable merging the change? How can we help facilitate this?

Thanks.

Bmastaz commented 1 year ago

can you approve this ? This is clearly broken in react with the same errors and need this fix.

jeffhuang commented 1 year ago

Still looking into it. I plan to test it with a few build processes, and merge shortly after. Thanks for your patience.

jeffhuang commented 1 year ago

merged, thank you!