search

brownhci / WebGazer

WebGazer.js: Scalable Webcam EyeTracking Using User Interactions
https://webgazer.cs.brown.edu
Other
3.54k stars 536 forks source link

fix bug `plotting-canvas` not spanning the entire screen #325

Closed TungVietLe closed 1 year ago

TungVietLe commented 1 year ago

Sometimes, plotting-canvas does not cover the entire screen. I my case, when I use npm run serve it will spans, but if I use npx lite-server, which is a local server, it somehow doesn't work. This is a fix on the CSS of setup() to guarantee it will span whole screen on every server

jeffhuang commented 1 year ago

Thanks @TungVietLe is it possible for you to only do the PR for the fix, without the whitespace changes? Or at least separate that out?

jeffhuang commented 1 year ago

Also I don't think we want to add jquery.js to the source like that. Can you exclude that change as well?

TungVietLe commented 1 year ago

sure thing, I will try to change it right now!

TungVietLe commented 1 year ago

i will make it a new pull request

jeffhuang commented 1 year ago

thank you!